Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deleted affiliation, binary, review analysis from hipcheck core #633

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

bmarr-mitre
Copy link
Contributor

Resolves #625.
Resolves #631
Resolves #632

Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, otherwise looks good.

hipcheck/src/metric/mod.rs Outdated Show resolved Hide resolved
@j-lanson j-lanson self-requested a review November 15, 2024 20:25
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment.

hipcheck/src/metric/mod.rs Outdated Show resolved Hide resolved
@bmarr-mitre bmarr-mitre force-pushed the remove-affiliation=binary-review branch from e5e49b0 to 4373bfa Compare November 18, 2024 20:00
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Brian

@j-lanson j-lanson merged commit fc6b9a1 into main Nov 19, 2024
9 checks passed
@alilleybrinker alilleybrinker deleted the remove-affiliation=binary-review branch November 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants